[kdewebdev-site] Weekend update

[Eric Laffoon]

On Friday 25 February 2005 04:51 pm, Joff wrote:
> On Saturday 26 February 2005 00:17, Eric Laffoon wrote:
> > On Friday 25 February 2005 02:45 pm, Joff wrote:
> > > On Friday 25 February 2005 22:21, Eric Laffoon wrote:
> > > > I ask that if you are on the list you join me in reviewing commits.
> > >
> > > Where do we see commits to be able to review them? (or am i being
> > > thick!)
> >
> > I presume you are familiar with Cervisia and using it?
> > http://www.osnews.com/story.php?news_id=6096
>
> ahh - I /was/ being thick, you're just too polite to say ;)

Did you see Andras? Joff thinks I'm polite. ;-)
>
> > Once you update they will be visible.
> >
> > > > In fact
> > > > if someone wants the task of site validity tester that is something I
> > > > would welcome. Quality control is important.
> > >
> > > just looking at http://kallery.kdewebdev.org/kdewebdev-test/index.php
> > > Not sure if this is just a pre-test site, or if this is what will
> > > become the test site, but either way it doesn't validate ;)
> >
> > Andras was using it for his test site. In fact every account currently
> > has a test site in their user account at
> > http://host202.creolmail.org/~[user] at /home/[user]/public_html.
> >
> > BTW thanks for noticing that. Feeling frisky Andras? ;-)
> >
> > > I presume that's what you mean by valid - w3c valid xhtml?
> >
> > That's a reasonable presumption. We want to produce an exemplary site for
> > obvious reasons. We want to be a good example. I doubt I'll get many
> > "good job, you validated" emails but my motivation does go beyond not
> > getting "hey stupid, can't you make a page that validates?" emails. ;-)
>
> lol - that's something we always aspire to with our work - ok, so who's
> gonna know that the site does/doesnt validate? I will !

I accept your nomination for QC.
>
> And you can put a "XHTML" and "CSS" link at the bottom of the page that
> links to the w3c/jigsaw validator.

Yeah, I know... write a footer include.
>
> A bit off topic here perhaps, but another thing i like to see is well
> formatted code, not sure why - it's just that when i view someone's source,
> if it's all over the place, or all on one line, it makes me cringe!

Oh we will expect to see well formatted code, but we won't be utterly annoying 
about it. I would like to see rational intention of markup, even in PHP 
generated code as much as possible, as well as for PHP.

I would like to see consistency, so I'll offer some suggestions for PHP.
1) unbracketed if - 
if (condition)
 execute;
These are okay, but they always seem to get people into trouble because you 
add something not paying attention or end up adding only one bracket. In  
general it seems good to bracket all conditionals.
2) bracket position - Andras likes to do it like so for C++
function (param)
{
 //exec
}
Which seems nice for classes, but I generally like 
function (param) {
 //exec
}
as it's more compact. It would be my preference, but I don't want to set a 
policy by caveat. However mixing them looks ugly and confusing.
3) switch rather than numerous else if statements - this seems to go with out 
saying that if there is a common comparator this is more readable

I did set out several conventions in the code I initially uploaded...
* manage local test and domain based presentation
* use $_variables for common layout variables
* make sure everything abstracts to single entries for repeated content 
whenever possible

One other thing, I use two spaces for tabs and ask others to do likewise on 
the site.
>
> > BTW Joff, do you have an account? I don't see a request from you, so this
> > may be why you don't see things. If you need an account go to
> > https://kittyhooch.com/kdewebdev.php.
>
> Aha! That's what i need to do.....!

And so you did.
>
> It's time for bed now, 12:50 am -  I really ought to get a life sometime
> soon ;)

Wow! That is luxurious! In bed before 3-5 AM? What is that kind of luxury 
like? How many businesses and open source projects again? ;-)
>
> Thanks Eric,

You are very welcome as always.
>
> Joff
-- 
Eric Laffoon
Project Lead - kdewebdev module